-
Notifications
You must be signed in to change notification settings - Fork 698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the worker-speedtest template (#5830) #5840
Conversation
The code had been converted to typescript in 026d944, but packages.json and several other places still refered to .js files. In addition a refactoring of the test code meant tests for both /up and /down urls were now being sent to the handler for /up, causing the tests to fail. I removed some of the test in up.test.ts since they were testing different values of the ?bytes= parameter, but this parameter is only used in down.ts, not in up.ts.
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9711551332/npm-package-wrangler-5840 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5840/npm-package-wrangler-5840 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9711551332/npm-package-wrangler-5840 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9711551332/npm-package-create-cloudflare-5840 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9711551332/npm-package-cloudflare-kv-asset-handler-5840 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9711551332/npm-package-miniflare-5840 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9711551332/npm-package-cloudflare-pages-shared-5840 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9711551332/npm-package-cloudflare-vitest-pool-workers-5840 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
Thanks for the approve @petebacondarwin ! |
Congratulations @nielsreijers, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cly5yd30w78580cl9zn7yhoh2 This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
The code had been converted to typescript in 026d944, but packages.json and several other places still refered to .js files.
In addition a refactoring of the test code meant tests for both /up and /down urls were now being sent to the handler for /up, causing the tests to fail. I removed some of the test in up.test.ts since they were testing different values of the ?bytes= parameter, but this parameter is only used in down.ts, not in up.ts.
What this PR solves / how to test
Fixes #5830.
Author has addressed the following