Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle more module declaration cases #6792

Merged
merged 3 commits into from
Oct 2, 2024
Merged

Conversation

penalosa
Copy link
Contributor

@penalosa penalosa commented Sep 20, 2024

What this PR solves / how to test

Fixes #6730

Handle more rule glob cases when generating declare module "..." { } types

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: no e2e coverage
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Changeset included
    • Changeset not necessary because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: bugfix

@penalosa penalosa requested a review from a team as a code owner September 20, 2024 17:50
Copy link

changeset-bot bot commented Sep 20, 2024

🦋 Changeset detected

Latest commit: a213c8a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@GregBrimble GregBrimble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never seen a TS module declaration with trailing * like folder/* but assuming that's fine, LGTM!

Copy link
Contributor

github-actions bot commented Sep 20, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11110975562/npm-package-wrangler-6792

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6792/npm-package-wrangler-6792

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11110975562/npm-package-wrangler-6792 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11110975562/npm-package-create-cloudflare-6792 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11110975562/npm-package-cloudflare-kv-asset-handler-6792
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11110975562/npm-package-miniflare-6792
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11110975562/npm-package-cloudflare-pages-shared-6792
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11110975562/npm-package-cloudflare-vitest-pool-workers-6792
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11110975562/npm-package-cloudflare-workers-editor-shared-6792
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11110975562/npm-package-cloudflare-workers-shared-6792

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.78.12 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240925.0
workerd 1.20240925.0 1.20240925.0
workerd --version 1.20240925.0 2024-09-25

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@penalosa penalosa merged commit 27e8385 into main Oct 2, 2024
23 checks passed
@penalosa penalosa deleted the penalosa/fix-type-modules branch October 2, 2024 23:10
@workers-devprod workers-devprod mentioned this pull request Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 BUG: Types generation fails for extensionless files in rules
3 participants