-
Notifications
You must be signed in to change notification settings - Fork 697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include serialised FormData in debug logs #6854
Conversation
🦋 Changeset detectedLatest commit: a5f5c1b The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
packages/wrangler/src/logger.ts
Outdated
@@ -108,7 +107,7 @@ export class Logger { | |||
} | |||
|
|||
// only send logs to the terminal if their level is at least the configured log-level | |||
if (LOGGER_LEVELS[this.loggerLevel] >= LOGGER_LEVELS[messageLevel]) { | |||
if (LOGGER_LEVELS[getLoggerLevel()] >= LOGGER_LEVELS[messageLevel]) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previously this.loggerLevel
was pretty much always stale in tests.
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11165666876/npm-package-wrangler-6854 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6854/npm-package-wrangler-6854 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11165666876/npm-package-wrangler-6854 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11165666876/npm-package-create-cloudflare-6854 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11165666876/npm-package-cloudflare-kv-asset-handler-6854 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11165666876/npm-package-miniflare-6854 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11165666876/npm-package-cloudflare-pages-shared-6854 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11165666876/npm-package-cloudflare-vitest-pool-workers-6854 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11165666876/npm-package-cloudflare-workers-editor-shared-6854 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11165666876/npm-package-cloudflare-workers-shared-6854 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
although those test failures look legit - probably shouldn't have approved womp |
What this PR solves / how to test
Fixes N/A
Author has addressed the following