Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix not-deterministic log message #6885

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

RamIdeas
Copy link
Contributor

@RamIdeas RamIdeas commented Oct 3, 2024

What this PR solves / how to test

Fixes #0000

Sometimes caused a snapshot mismatch eg https://github.com/cloudflare/workers-sdk/actions/runs/11161082325/job/31022879309#step:5:1

Simple fix to ensure the order is deterministic

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: unit tested
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Changeset included
    • Changeset not necessary because: not user facing – decreases test flakiness
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: not user facing

@RamIdeas RamIdeas requested a review from a team as a code owner October 3, 2024 16:32
Copy link

changeset-bot bot commented Oct 3, 2024

⚠️ No Changeset found

Latest commit: fb72615

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 3, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11165930873/npm-package-wrangler-6885

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6885/npm-package-wrangler-6885

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11165930873/npm-package-wrangler-6885 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11165930873/npm-package-create-cloudflare-6885 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11165930873/npm-package-cloudflare-kv-asset-handler-6885
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11165930873/npm-package-miniflare-6885
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11165930873/npm-package-cloudflare-pages-shared-6885
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11165930873/npm-package-cloudflare-vitest-pool-workers-6885
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11165930873/npm-package-cloudflare-workers-editor-shared-6885
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11165930873/npm-package-cloudflare-workers-shared-6885

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.79.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240925.0
workerd 1.20240925.0 1.20240925.0
workerd --version 1.20240925.0 2024-09-25

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the lists in the original snapshot were already sorted?

@RamIdeas
Copy link
Contributor Author

RamIdeas commented Oct 3, 2024

I guess the lists in the original snapshot were already sorted?

Yep. Ran an update snapshot run with no changes.

@petebacondarwin petebacondarwin merged commit 1d1a04d into main Oct 4, 2024
20 of 21 checks passed
@petebacondarwin petebacondarwin deleted the fix-non-deterministic-log-message branch October 4, 2024 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants