Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: relax PR description validation #6964

Merged
merged 1 commit into from
Oct 15, 2024
Merged

fix: relax PR description validation #6964

merged 1 commit into from
Oct 15, 2024

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Oct 14, 2024

The validation expects /\[x\]/ for checkboxes while github accepts /\[x\]/i. This PR then makes the whole regexps case insensitive as case should not matter anyway.

Also removed a bunch a unnecessary snapshots.

I had the description test failed on #6957 because of that.

What this PR solves / how to test

Fixes N/A.

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Changeset included
    • Changeset not necessary because: CI fix
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: CI fix

The validation expects `/\[x\]/` for checkboxes while github accepts `/\[x\]/i`.
This PR then makes the whole regexps case insensitive as case should not matter anyway.
@vicb vicb added the e2e Run e2e tests on a PR label Oct 14, 2024
@vicb vicb requested a review from a team as a code owner October 14, 2024 19:07
Copy link

changeset-bot bot commented Oct 14, 2024

⚠️ No Changeset found

Latest commit: b6d6ce4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11333560630/npm-package-wrangler-6964

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6964/npm-package-wrangler-6964

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11333560630/npm-package-wrangler-6964 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11333560630/npm-package-create-cloudflare-6964 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11333560630/npm-package-cloudflare-kv-asset-handler-6964
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11333560630/npm-package-miniflare-6964
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11333560630/npm-package-cloudflare-pages-shared-6964
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11333560630/npm-package-cloudflare-vitest-pool-workers-6964
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11333560630/npm-package-cloudflare-workers-editor-shared-6964
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11333560630/npm-package-cloudflare-workers-shared-6964

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.80.4 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241004.0
workerd 1.20241004.0 1.20241004.0
workerd --version 1.20241004.0 2024-10-04

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@vicb vicb added the skip-pr-description-validation Skip validation of the required PR description format label Oct 14, 2024
@penalosa penalosa removed the skip-pr-description-validation Skip validation of the required PR description format label Oct 14, 2024
@vicb vicb merged commit 9b5910f into main Oct 15, 2024
40 of 44 checks passed
@vicb vicb deleted the relax/desc branch October 15, 2024 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e tests on a PR
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants