Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIPE-37 Add authenticated HTTP source options to Worker Pipelines #6970

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

oliy
Copy link
Contributor

@oliy oliy commented Oct 15, 2024

What this PR solves / how to test

Fixes PIPE-37 (Support Authenticated HTTP Source in Worker Pipelines)

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: covered by unit tests
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Changeset included
    • Changeset not necessary because: Not sure, but this is a small feature on existing functionality
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: New docs are being created by PM for first experience docs.

@oliy oliy requested a review from a team as a code owner October 15, 2024 06:23
Copy link

changeset-bot bot commented Oct 15, 2024

🦋 Changeset detected

Latest commit: 0edc431

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Minor
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 15, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11442744341/npm-package-wrangler-6970

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6970/npm-package-wrangler-6970

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11442744341/npm-package-wrangler-6970 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11442744341/npm-package-create-cloudflare-6970 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11442744341/npm-package-cloudflare-kv-asset-handler-6970
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11442744341/npm-package-miniflare-6970
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11442744341/npm-package-cloudflare-pages-shared-6970
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11442744341/npm-package-cloudflare-vitest-pool-workers-6970
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11442744341/npm-package-cloudflare-workers-editor-shared-6970
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11442744341/npm-package-cloudflare-workers-shared-6970

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.81.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241011.0
workerd 1.20241018.1 1.20241018.1
workerd --version 1.20241018.1 2024-10-18

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link
Contributor

@CarmenPopoviciu CarmenPopoviciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome stuff ♥️ !! Left a few nits that would make this PR even more awesome 😋

@CarmenPopoviciu CarmenPopoviciu added skip-pr-description-validation Skip validation of the required PR description format and removed skip-pr-description-validation Skip validation of the required PR description format labels Oct 21, 2024
@CarmenPopoviciu CarmenPopoviciu merged commit a8ca700 into cloudflare:main Oct 21, 2024
25 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants