fix: log successful execution of D1 commands locally #7018
Conversation
🦋 Changeset detectedLatest commit: e4c377a The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11445245334/npm-package-wrangler-7018You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7018/npm-package-wrangler-7018Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11445245334/npm-package-wrangler-7018 dev path/to/script.jsAdditional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11445245334/npm-package-create-cloudflare-7018 --no-auto-updatenpm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11445245334/npm-package-cloudflare-kv-asset-handler-7018npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11445245334/npm-package-miniflare-7018npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11445245334/npm-package-cloudflare-pages-shared-7018npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11445245334/npm-package-cloudflare-vitest-pool-workers-7018npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11445245334/npm-package-cloudflare-workers-editor-shared-7018npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11445245334/npm-package-cloudflare-workers-shared-7018Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
emily-shen
force-pushed
the
emily/print-asset-binding
branch
from
479b173
to
0c45920
Compare
emily-shen
added
the
skip-pr-description-validation
emily-shen
force-pushed
the
emily/print-asset-binding
branch
from
d15106f
to
cf5add2
Compare
| @@ -332,6 +332,12 @@ async function executeLocally({ | |||
| success: result.success, | |||
| meta: { duration: result.meta?.duration }, | |||
| })); | |||
| if (allResults.every((r) => r.success)) { | |||
| logger.log( | |||
| `🚣 ${allResults.length} command${allResults.length === 1 ? "" : "s"} executed successfully.` | |||
There was a problem hiding this comment.
do we really need that emoji here?
There was a problem hiding this comment.
Haha I'm just mimicking what gets logged out when something is executed in remote mode. That seems to throw a random canoe in there, so why not in local too ¯\_(ツ)_/¯
What this PR solves / how to test
Fixes #6938
Already does this for remote, just logs a bit of feedback to the user for local as well.
Author has addressed the following