Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try and ensure the d.ts types are definitely the ones loaded in quick-edit-extension #7040

Merged
merged 3 commits into from
Oct 21, 2024

Conversation

penalosa
Copy link
Contributor

Make sure we're loading the .d.ts and not the .ts version of the types. Occasionally the wrong version has been loaded in CI, causing spurious typing errors for users in the playground & quick edit. This PR simplifies the loading, and adds an assertion to make sure builds will fail if the wrong version is loaded.


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: tooling change
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: tooling change
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: internal tooling change

@penalosa penalosa requested a review from a team as a code owner October 21, 2024 13:54
Copy link

changeset-bot bot commented Oct 21, 2024

🦋 Changeset detected

Latest commit: 3762311

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudflare/quick-edit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 21, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11441903078/npm-package-wrangler-7040

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7040/npm-package-wrangler-7040

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11441903078/npm-package-wrangler-7040 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11441903078/npm-package-create-cloudflare-7040 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11441903078/npm-package-cloudflare-kv-asset-handler-7040
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11441903078/npm-package-miniflare-7040
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11441903078/npm-package-cloudflare-pages-shared-7040
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11441903078/npm-package-cloudflare-vitest-pool-workers-7040
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11441903078/npm-package-cloudflare-workers-editor-shared-7040
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11441903078/npm-package-cloudflare-workers-shared-7040

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.81.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241011.0
workerd 1.20241018.1 1.20241018.1
workerd --version 1.20241018.1 2024-10-18

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@penalosa penalosa merged commit 44c954b into main Oct 21, 2024
20 checks passed
@penalosa penalosa deleted the penalosa/fix-workers-types-loading branch October 21, 2024 14:14
@penalosa penalosa added the preview:quick-edit Trigger a quick edit preview deploy label Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview:quick-edit Trigger a quick edit preview deploy
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants