Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix workflow trigger params serialization #7075

Merged
merged 3 commits into from
Oct 23, 2024

Conversation

LuisDuarte1
Copy link
Contributor

@LuisDuarte1 LuisDuarte1 commented Oct 23, 2024

Fixes WOR-298

We were not sending the parsed json to the Workflow's API which would make everthing a string. This ensures that the params are parsed.


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: it's coming after beta
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: it's coming after beta
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: it's just a fix

@LuisDuarte1 LuisDuarte1 requested a review from a team as a code owner October 23, 2024 20:07
Copy link

changeset-bot bot commented Oct 23, 2024

🦋 Changeset detected

Latest commit: 94c553b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11487340848/npm-package-wrangler-7075

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7075/npm-package-wrangler-7075

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11487340848/npm-package-wrangler-7075 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11487340848/npm-package-create-cloudflare-7075 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11487340848/npm-package-cloudflare-kv-asset-handler-7075
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11487340848/npm-package-miniflare-7075
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11487340848/npm-package-cloudflare-pages-shared-7075
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11487340848/npm-package-cloudflare-vitest-pool-workers-7075
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11487340848/npm-package-cloudflare-workers-editor-shared-7075
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11487340848/npm-package-cloudflare-workers-shared-7075

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.82.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241018.0
workerd 1.20241022.0 1.20241022.0
workerd --version 1.20241022.0 2024-10-22

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@emily-shen emily-shen merged commit 80e5bc6 into main Oct 23, 2024
20 checks passed
@emily-shen emily-shen deleted the lduarte/fix-trigger-command-serialization branch October 23, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants