Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update & consolidate some repo dependencies #7090

Merged
merged 9 commits into from
Oct 25, 2024
Merged

Update & consolidate some repo dependencies #7090

merged 9 commits into from
Oct 25, 2024

Conversation

penalosa
Copy link
Contributor

@penalosa penalosa commented Oct 24, 2024

  • Moves more deps to the catalog, including undici & typescript
  • Updating Typescript + @types/node@18 to the latest
  • Updated ws@7.x to the latest patch version in Wrangler's bundle, resolving a semgrep issue (included via ink)

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: covered by existing tests
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: covered by existing tests
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: dep upgrades

Copy link

changeset-bot bot commented Oct 24, 2024

⚠️ No Changeset found

Latest commit: cb24802

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 24, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11522038735/npm-package-wrangler-7090

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7090/npm-package-wrangler-7090

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11522038735/npm-package-wrangler-7090 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11522038735/npm-package-create-cloudflare-7090 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11522038735/npm-package-cloudflare-kv-asset-handler-7090
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11522038735/npm-package-miniflare-7090
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11522038735/npm-package-cloudflare-pages-shared-7090
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11522038735/npm-package-cloudflare-vitest-pool-workers-7090
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11522038735/npm-package-cloudflare-workers-editor-shared-7090
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11522038735/npm-package-cloudflare-workers-shared-7090
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11522038735/npm-package-cloudflare-workflows-shared-7090

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.83.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241022.0
workerd 1.20241022.0 1.20241022.0
workerd --version 1.20241022.0 2024-10-22

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@penalosa penalosa marked this pull request as ready for review October 24, 2024 21:19
@penalosa penalosa requested review from a team as code owners October 24, 2024 21:19
@emily-shen
Copy link
Contributor

Fixes #7094

Copy link
Contributor

@IgorMinar IgorMinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a great improvement! thank you @penalosa

@penalosa penalosa merged commit 0a38bba into main Oct 25, 2024
31 checks passed
@penalosa penalosa deleted the penalosa/deps-3 branch October 25, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants