Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore turbo loose mode #7102

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Restore turbo loose mode #7102

wants to merge 1 commit into from

Conversation

penalosa
Copy link
Contributor

Restore turbo loose mode after a change in defaults after Turbo v2: https://turbo.build/blog/turbo-2-0#correctness

(we can investigate strict mode as a follow-up, but this is currently causing our tests to fail and so is an okay bandaid)


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: tooling
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: tooling

@penalosa penalosa added the e2e Run e2e tests on a PR label Oct 25, 2024
@penalosa penalosa requested a review from a team as a code owner October 25, 2024 19:11
Copy link

changeset-bot bot commented Oct 25, 2024

⚠️ No Changeset found

Latest commit: ec5d31e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11524052983/npm-package-wrangler-7102

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7102/npm-package-wrangler-7102

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11524052983/npm-package-wrangler-7102 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11524052983/npm-package-create-cloudflare-7102 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11524052983/npm-package-cloudflare-kv-asset-handler-7102
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11524052983/npm-package-miniflare-7102
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11524052983/npm-package-cloudflare-pages-shared-7102
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11524052983/npm-package-cloudflare-vitest-pool-workers-7102
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11524052983/npm-package-cloudflare-workers-editor-shared-7102
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11524052983/npm-package-cloudflare-workers-shared-7102
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11524052983/npm-package-cloudflare-workflows-shared-7102

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.83.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241022.0
workerd 1.20241022.0 1.20241022.0
workerd --version 1.20241022.0 2024-10-22

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e tests on a PR
Projects
Status: Untriaged
Development

Successfully merging this pull request may close these issues.

2 participants