Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the framework name #7109

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Rename the framework name #7109

wants to merge 3 commits into from

Conversation

jsparkdev
Copy link

@jsparkdev jsparkdev commented Oct 28, 2024

The name currently displayed in the CLI is Svelte. However, all of the options actually create a SvelteKit app, and the name SvelteKit is also used in the documentation.

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: it matches existing features with documentation.

@jsparkdev jsparkdev requested review from a team as code owners October 28, 2024 04:32
Copy link

changeset-bot bot commented Oct 28, 2024

🦋 Changeset detected

Latest commit: 9382b80

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@dario-piotrowicz dario-piotrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a bunch for the PR @jsparkdev 🙂

However I think that this is a duplicate of #6565

Also this has been an issue for a while: #3263 I think we should definitely clarify things 😕 (personally I think we should indeed go with SvelteKit instead of Svelte, but I am not sure if I can make the call all by myself... it's probably something I need to check with the team)

cc. @penalosa

@jsparkdev
Copy link
Author

@dario-piotrowicz

Thank you! That's a lot of discussion!

So, do you think it's a good idea to close this PR?

@dario-piotrowicz
Copy link
Member

Hey @jsparkdev 🙂

yeah closing this PR is what I was thinking but @penalosa's PR is a bit outdated now and I think they will not be available in the next few days... so might be worth it to keep going with this PR? 🤔

Let me just check with the team, if there are no objections regarding the renaming I'd go forward with this one maybe 🤔

@jsparkdev
Copy link
Author

@dario-piotrowicz Thanks for the kind explanation. I'll keep this PR then :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants