deflate should use __builtin_ctzll (64bit) instead of __builtin_ctzl (32bit) #60
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the use of the 32bit operation is probably a mistake. It seems to leave an appreciable amount of compression on the table, perhaps by finding shorter matches (4 bytes) in cases where there may have been 5-8. I did not assess the performance implications. I did check the upstream code and the intention seems to have been to SWAR a fundamentally 8-byte serial process, but this intention was not achieved with the 32bit operation.
If my analysis is wrong for some arcane reason, then I think it warrants explaining in a comment at the point of the call why the strange choice was made.