This repository has been archived by the owner on Oct 22, 2021. It is now read-only.
Bump golang dependencies #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commands used to bump dependencies ``` go get -t -u ./... go mod tidy ``` We had to pin the versions below as they have eveloved incompatibly * github.com/coreos/bbolt to v1.3.0 * google.golang.org/grpc to v1.29.1 Those are transitive dependencies pulled by `github.com/google/certificate-transparency-go` which has not adopted newer versions yet We also had to pin `k8s.io/client-go` to `v0.19.2` as bumping depdndencies with the commands above brings v11.0.0 which is a pretty old tag We also fixed the script to generate counterfeiter fakes as it seems that the syntax of the `generate` command in newer versions changed. [#175054068] Co-authored-by: Georgi Dankov <gddankov@gmail.com> Co-authored-by: Danail Branekov <danailster@gmail.com>
mudler
reviewed
Oct 5, 2020
| @@ -1,22 +1,80 @@ | |||
| module code.cloudfoundry.org/eirinix | |||
|
|
|||
| replace ( | |||
| github.com/coreos/bbolt => github.com/coreos/bbolt v1.3.0 | |||
| google.golang.org/grpc => google.golang.org/grpc v1.29.1 | |||
There was a problem hiding this comment.
just as a reminder: golang/go#30354
modules depending on won't respect the replace directive, so for e.g. grpc here is affected
There was a problem hiding this comment.
Sigh... I know that. Without those replace statements the code does not compile :( We have the very same replace lines in Eirini as well.
I wish people (I am looking at you, Google) bumped their dependencies more regularly!
mudler
approved these changes
Oct 5, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commands used to bump dependencies
We had to pin the versions below as they have eveloved incompatibly
Those are transitive dependencies pulled by
github.com/google/certificate-transparency-gowhich has not adopted newer versions yetWe also had to pin
k8s.io/client-gotov0.19.2as bumpingdepdndencies with the commands above brings v11.0.0 which is a pretty
old tag
We also fixed the script to generate counterfeiter fakes as it seems
that the syntax of the
generatecommand in newer versions changed.[#175054068]
Co-authored-by: Georgi Dankov gddankov@gmail.com
Co-authored-by: Danail Branekov danailster@gmail.com