Skip to content
This repository has been archived by the owner on Oct 22, 2021. It is now read-only.

Commit

Permalink
Remove max in flight and add every in the concourse pipeline
Browse files Browse the repository at this point in the history
we introduced max-in-flight hoping to limit the number of clusters we
run at the same time. It turns out it doesn't work that way. As soon as
a deploy job is done the next one will be queued although no cluster has
been deleted. This will allow for as many clusters as we have time to
deploy until the first cluster is deleteted.

We also add the "version: every" setting to make sure we don't skip
versions if jobs complete in random order. See also here:

concourse/concourse#736

Signed-off-by: Dimitris Karakasilis <DKarakasilis@suse.com>
  • Loading branch information
mudler authored and Dimitris Karakasilis committed Mar 6, 2020
1 parent a2ab3da commit 2056c9b
Showing 1 changed file with 16 additions and 10 deletions.
26 changes: 16 additions & 10 deletions .concourse/pipeline.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,7 @@ jobs:
params:
integration_tool: checkout
trigger: true
version: "every"
# Use GitHub API to find the remote repository of the PR (it may be a fork)
# The pr resource doesn't provide this information.
- task: find-pr-remote
Expand Down Expand Up @@ -249,6 +250,7 @@ jobs:
plan:
- get: commit-to-test
trigger: true
version: "every"
- task: lint
config:
platform: linux
Expand Down Expand Up @@ -289,6 +291,7 @@ jobs:
plan:
- get: commit-to-test
trigger: true
version: "every"
passed:
- lint
- task: build
Expand Down Expand Up @@ -342,6 +345,7 @@ jobs:
plan:
- get: commit-to-test
trigger: true
version: "every"
passed:
- build
- get: s3.kubecf-ci
Expand Down Expand Up @@ -421,13 +425,13 @@ jobs:
EKCP_HOST: ((ekcp-host))

- name: smoke-tests-diego
max_in_flight: 2
public: true
plan:
- get: commit-to-test
passed:
- deploy-diego
trigger: true
version: "every"
- get: s3.kubecf-ci
passed:
- deploy-diego
Expand Down Expand Up @@ -490,12 +494,12 @@ jobs:

- name: ccdb-rotate-diego
public: true
max_in_flight: 2
plan:
- get: commit-to-test
passed:
- cf-acceptance-tests-diego
trigger: true
version: "every"
- get: s3.kubecf-ci
passed:
- cf-acceptance-tests-diego
Expand Down Expand Up @@ -556,13 +560,13 @@ jobs:
EKCP_HOST: ((ekcp-host))

- name: smoke-tests-post-rotate-diego
max_in_flight: 2
public: true
plan:
- get: commit-to-test
passed:
- ccdb-rotate-diego
trigger: true
version: "every"
- get: s3.kubecf-ci
passed:
- ccdb-rotate-diego
Expand Down Expand Up @@ -624,13 +628,13 @@ jobs:
EKCP_HOST: ((ekcp-host))

- name: cf-acceptance-tests-diego
max_in_flight: 2
public: true
plan:
- get: commit-to-test
passed:
- smoke-tests-diego
trigger: true
version: "every"
- get: s3.kubecf-ci
passed:
- smoke-tests-diego
Expand Down Expand Up @@ -692,13 +696,13 @@ jobs:
EKCP_HOST: ((ekcp-host))

- name: cleanup-diego-cluster
max_in_flight: 2
public: true
plan:
- get: commit-to-test
passed:
- smoke-tests-post-rotate-diego
trigger: true
version: "every"
- task: cleanup-cluster
config:
<<: *cleanup-cluster
Expand All @@ -713,6 +717,7 @@ jobs:
plan:
- get: commit-to-test
trigger: true
version: "every"
passed:
- build
- get: s3.kubecf-ci
Expand Down Expand Up @@ -777,13 +782,13 @@ jobs:
EKCP_HOST: ((ekcp-host))

- name: smoke-tests-eirini
max_in_flight: 2
public: true
plan:
- get: commit-to-test
passed:
- deploy-eirini
trigger: true
version: "every"
- get: s3.kubecf-ci
passed:
- deploy-eirini
Expand Down Expand Up @@ -846,12 +851,12 @@ jobs:

- name: ccdb-rotate-eirini
public: true
max_in_flight: 2
plan:
- get: commit-to-test
passed:
- cf-acceptance-tests-eirini
trigger: true
version: "every"
- get: s3.kubecf-ci
passed:
- cf-acceptance-tests-eirini
Expand Down Expand Up @@ -912,13 +917,13 @@ jobs:
EKCP_HOST: ((ekcp-host))

- name: smoke-tests-post-rotate-eirini
max_in_flight: 2
public: true
plan:
- get: commit-to-test
passed:
- ccdb-rotate-eirini
trigger: true
version: "every"
- get: s3.kubecf-ci
passed:
- ccdb-rotate-eirini
Expand Down Expand Up @@ -980,13 +985,13 @@ jobs:
EKCP_HOST: ((ekcp-host))

- name: cf-acceptance-tests-eirini
max_in_flight: 2
public: true
plan:
- get: commit-to-test
passed:
- smoke-tests-eirini
# trigger: true
version: "every"
- get: s3.kubecf-ci
passed:
- smoke-tests-eirini
Expand Down Expand Up @@ -1048,14 +1053,14 @@ jobs:
EKCP_HOST: ((ekcp-host))

- name: cleanup-eirini-cluster
max_in_flight: 2
public: true
plan:
- get: commit-to-test
passed:
# - smoke-tests-post-rotate-eirini
- smoke-tests-eirini
trigger: true
version: "every"
- task: cleanup-cluster
config:
<<: *cleanup-cluster
Expand All @@ -1067,6 +1072,7 @@ jobs:
public: true
plan:
- get: commit-to-test
version: "every"
passed:
- cf-acceptance-tests-diego
# TODO: Uncomment as soon as eirini tests are green
Expand Down

0 comments on commit 2056c9b

Please sign in to comment.