Skip to content
This repository has been archived by the owner on Oct 22, 2021. It is now read-only.

Remove "version: every" when "passed:" contraints are defined #1243

Merged
merged 2 commits into from
Aug 21, 2020

Conversation

jimmykarily
Copy link
Collaborator

because that blocks automatic triggering of jobs

concourse/concourse#736

This combination of settting was introduced when we tried to force
Concourse to run later jobs on every version that passed the previous
one. E.g.
ver1 passed job 1, ver2 passed job 1
job2 should trigger both for ver1 and ver2 otherwise ver1 would never
be tested on job2. The new scheduling algorighm may have solved this:

https://concourse-ci.org/scheduler.html#scheduling-behavior

Given our pipeline needs us to manually trigger jobs all the time, this
worths a shot.

because that blocks automatic triggering of jobs

concourse/concourse#736

This combination of settting was introduced when we tried to force
Concourse to run later jobs on every version that passed the previous
one. E.g.
ver1 passed job 1, ver2 passed job 1
job2 should trigger both for ver1 and ver2 otherwise ver1 would never
be tested on job2. The new scheduling algorighm may have solved this:

https://concourse-ci.org/scheduler.html#scheduling-behavior

Given our pipeline needs us to manually trigger jobs all the time, this
worths a shot.
@jimmykarily
Copy link
Collaborator Author

See "Breaking change" here: https://github.com/concourse/concourse/releases/tag/v6.0.0

@cfcontainerizationbot cfcontainerizationbot added the pr-test-queue PRs with this label get tested label Aug 21, 2020
@github-actions github-actions bot removed the pr-test-queue PRs with this label get tested label Aug 21, 2020
@jandubois jandubois merged commit 274ed10 into master Aug 21, 2020
@jandubois jandubois deleted the fix_concourse_triggering branch August 21, 2020 21:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants