Skip to content
This repository has been archived by the owner on Oct 22, 2021. It is now read-only.

feat: update enc key rotation docs #854

Merged
merged 4 commits into from
May 28, 2020

Conversation

jandubois
Copy link
Member

Rename docs to secret_rotation and encryption_key_rotation to more closely match what they contain.

Add an addition section to encryption key rotation to document requirements for importing data from another installation.

@jandubois jandubois requested a review from f0rmiga May 11, 2020 23:23
@jandubois
Copy link
Member Author

The doc changes assume #853 has been merged.

@gaktive gaktive removed the request for review from f0rmiga May 19, 2020 16:00
Copy link
Contributor

@mook-as mook-as left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the CC key rotation bit could use a tiny bit more clarification. That or I can't think straight anymore.

doc/encryption_key_rotation.md Outdated Show resolved Hide resolved
doc/encryption_key_rotation.md Show resolved Hide resolved
doc/encryption_key_rotation.md Outdated Show resolved Hide resolved
doc/secret_rotation.md Outdated Show resolved Hide resolved
@jandubois jandubois requested a review from mook-as May 28, 2020 01:35
mook-as
mook-as previously approved these changes May 28, 2020
Copy link
Contributor

@mook-as mook-as left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think explaining the example explicitly would help; approved whether or not you agree on that point :)

doc/encryption_key_rotation.md Outdated Show resolved Hide resolved
Co-authored-by: Mark Yen <3977982+mook-as@users.noreply.github.com>
@jandubois jandubois merged commit 624df61 into master May 28, 2020
@jandubois jandubois deleted the jandubois/update-enc-key-rotation-docs branch May 28, 2020 23:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants