Skip to content
This repository has been archived by the owner on Oct 22, 2021. It is now read-only.

Remove version: "every" from publish step artifacts #982

Merged
merged 1 commit into from
Jun 4, 2020

Conversation

jimmykarily
Copy link
Collaborator

because this together with passed: is confusing to Concourse and
doesn't let the step trigger when it should.

See also: concourse/concourse#736 (comment)

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code has security implications.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

because this together with `passed:` is confusing to Concourse and
doesn't let the step trigger when it should.

See also: concourse/concourse#736 (comment)
@jimmykarily jimmykarily requested review from mudler and thardeck June 4, 2020 07:02
@jimmykarily
Copy link
Collaborator Author

According to this though, it should work (?): https://concourse-ci.org/jobs.html#schema.step.get-step.version

If set to every, builds will walk through all available versions of the resource. Note that if passed is also configured, it will only step through the versions satisfying the constraints.

@jimmykarily jimmykarily merged commit 344ace2 into master Jun 4, 2020
@jimmykarily jimmykarily deleted the fix_publish_step branch June 4, 2020 08:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants