This repository has been archived by the owner on Dec 1, 2021. It is now read-only.
scheduler synchronize rest api issue: when policy is updated without … #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…schedule, the old schedules do not deleted. [#159327430]
|
Hey qibobo! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/159328855 The labels on this github issue will be updated when the story is started. |
boyang9527
reviewed
Jul 30, 2018
| }else{ | ||
| // there is no schedule in the new policy, so the old schedules of this app should be deleted. | ||
| toDeletedAppIds.add(appIdInPolicy); | ||
| deleteCount++; |
There was a problem hiding this comment.
this is still update, not deleteCount
|
@boyang9527 updated. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…schedule, the old schedules do not deleted.
[#159327430]