Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Variable to make AWS ELB idle timeout configurable #564

Merged
merged 1 commit into from
May 4, 2023
Merged

Variable to make AWS ELB idle timeout configurable #564

merged 1 commit into from
May 4, 2023

Conversation

jochenehret
Copy link
Contributor

  • we need a longer idle timeout than the default 60s for some tests

@jochenehret
Variable to make AWS ELB idle timeout configurable
e5f5f4d 
* we need a longer idle timeout than the default 60s for some tests
@jochenehret
Copy link
Contributor Author

We'd like to override the default idle timeout for AWS ELBs. We tried to use a Terraform _override.tf file, but this does not work because there is no "idle_timeout" variable configured in the base template. Introducing a new Terraform variable should be the easiest way.

@rkoster rkoster requested review from a team, ystros, selzoc and ramonskie and removed request for a team May 4, 2023 14:36
ramonskie
ramonskie approved these changes May 4, 2023
View reviewed changes
Copy link
Contributor

@ramonskie ramonskie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rkoster rkoster merged commit 987b2ba into cloudfoundry:main May 4, 2023
@rkoster
Copy link

rkoster commented May 4, 2023

Thanks! @jochenehret

jochenehret added a commit to sap-contributions/cf-performance-tests-pipeline that referenced this pull request May 24, 2023
@jochenehret
Update to bosh-bootloader v9
5344a94 
* remove elb-idle-timeout override (has been made configurable with cloudfoundry/bosh-bootloader#564)
* add vars file with timeout and parent zone configuration
@jochenehret jochenehret mentioned this pull request May 24, 2023
Merged
jochenehret added a commit to sap-contributions/cf-performance-tests-pipeline that referenced this pull request May 25, 2023
@jochenehret
Use elb_idle_timeout Terraform variable
3865167 
* was introduced in bbl with cloudfoundry/bosh-bootloader#564
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramonskie ramonskie ramonskie approved these changes

@rkoster rkoster rkoster approved these changes

@ystros ystros Awaiting requested review from ystros ystros was automatically assigned from cloudfoundry/wg-foundational-infrastructure-vm-deployment-lifecycle-bosh-approvers

@selzoc selzoc Awaiting requested review from selzoc selzoc was automatically assigned from cloudfoundry/wg-foundational-infrastructure-vm-deployment-lifecycle-bosh-approvers

Assignees
No one assigned
Labels
None yet
Projects
Foundational Infrastructure Working Group
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jochenehret @rkoster @ramonskie @cf-gitbot