Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix azure templates according to the newer terraform versions #565

Merged
merged 2 commits into from
May 10, 2023
Merged

Fix azure templates according to the newer terraform versions #565

merged 2 commits into from
May 10, 2023

Conversation

ten4o
Copy link
Contributor

@ten4o ten4o commented May 4, 2023

Newer version of terraform introduced changes to the template syntax.
This PR fixes all Azure templates so that:

bbl up
bbl plan --lb-type concourse && bbl up
bbl plan --lb-type cf ....  && bbl up

all execute without errors.

@rkoster
Copy link

rkoster commented May 4, 2023

@ten4o @ivo4311 Thanks for this awsome PR, could y'all also take a look at the plan patches for Azure, given that y'all now have the required context on this?

@rkoster rkoster requested review from a team, lnguyen, bgandon and ramonskie and removed request for a team May 4, 2023 14:41
lnguyen
lnguyen approved these changes May 4, 2023
View reviewed changes
Copy link
Member

@lnguyen lnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ramonskie ramonskie merged commit 9c1a6d7 into cloudfoundry:main May 10, 2023
@ten4o
Copy link
Contributor Author

ten4o commented May 10, 2023

@rkoster @ramonskie I've made changes to the plan-patches related to Azure. Unfortunately I have no clue how to test them.

@ramonskie
Copy link
Contributor

no worries.
thank you for the contribution @ten4o

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramonskie ramonskie ramonskie approved these changes

@lnguyen lnguyen lnguyen approved these changes

@bgandon bgandon Awaiting requested review from bgandon bgandon was automatically assigned from cloudfoundry/wg-foundational-infrastructure-vm-deployment-lifecycle-bosh-approvers

Assignees
No one assigned
Labels
None yet
Projects
Foundational Infrastructure Working Group
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ten4o @rkoster @ramonskie @lnguyen @cf-gitbot