Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] About release v6.4.8 #578

Closed
chenrui333 opened this issue Nov 21, 2021 · 5 comments
Closed

[Question] About release v6.4.8 #578

chenrui333 opened this issue Nov 21, 2021 · 5 comments

Comments

@chenrui333
Copy link

👋 Just to check if the v6.4.8 is intended to be the latest release. If so, it would be better to mark the release as latest release. Thanks!

Also, it looks like the commit got re-tagged from the latest release which caused the checksum mismatch for go 1.17.3 update on the homebrew side.

@beyhan
Copy link
Member

beyhan commented Nov 23, 2021

@rkoster the release v6.4.8 is in draft mode. Is it a manual process to publish it or did some automation break here?

@chenrui333 I couldn't follow on the second part. What do you mean the "commit got re-tagged from the latest release..."?

@rkoster
Copy link
Contributor

rkoster commented Nov 23, 2021

v6.4.8 has been published, thanks @chenrui333 for bringing this up. Not really sure what to do about the checksum mismatch. Could you maybe describe the solution you are seeing for the case where the re-tagging has already happened? Or is this more a heads up to not re-tagg going forward?

@iMichka
Copy link

iMichka commented Dec 7, 2021

Hi. I'm also a homebrew maintainer.
Thanks for the information.

Ideally you should not retag, if possible. Some projects use "x.y.z.RC" tags, or "alpha/beta" tags. You could also mark it as "pre-release" in GitHub too; with should trigger a warning on our side.

You can close here as the situation has been mitigated.

iMichka added a commit to iMichka/homebrew-core that referenced this issue Dec 7, 2021
@carlocab
Copy link

carlocab commented Dec 7, 2021

Re-tags should be avoided where possible. Where avoiding them isn't possible, the re-tag should be made as conspicuous as possible.

See the Git docs for more in this; it actually has some rather strong words about re-tagging.

BrewTestBot pushed a commit to Homebrew/homebrew-core that referenced this issue Dec 8, 2021
See:
cloudfoundry/bosh-cli#578

Closes #90669.

Signed-off-by: rui <rui@chenrui.dev>
Signed-off-by: BrewTestBot <1589480+BrewTestBot@users.noreply.github.com>
@rkoster
Copy link
Contributor

rkoster commented Dec 8, 2021

Closing issue since it has been mitigated on the homebrew side of things

@rkoster rkoster closed this as completed Dec 8, 2021
Repository owner moved this from Pending Review | Discussion to Done in Foundational Infrastructure Working Group Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

6 participants