Adjustments to fix linter issues

cloudfoundry · Sep 11, 2023 · ca54f5d · ca54f5d
1 parent 0b97750
commit ca54f5d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/collectors/service_discovery_collector.go b/collectors/service_discovery_collector.go
@@ -53,9 +53,7 @@ func (labelGroupValue *LabelGroupValue) addTarget(ip string) {
 
 func (labelGroupValue *LabelGroupValue) exportReleasesAsString() string {
 	var releases []string
-	for _, release := range labelGroupValue.DeploymentReleases {
-		releases = append(releases, release)
-	}
+	releases = append(releases, labelGroupValue.DeploymentReleases...)
 	return strings.Join(releases, ",")
 }
 

diff --git a/deployments/deployments_fetcher.go b/deployments/deployments_fetcher.go
@@ -170,6 +170,9 @@ func (f *Fetcher) fetchDeploymentReleases(deployment director.Deployment) ([]Rel
 
 	for _, release := range releases {
 		jobNames, err := f.fetchReleaseJobs(release, deployment.Name())
+		if err != nil {
+			return deploymentReleases, err
+		}
 		packageNames, err := f.fetchReleasePackages(release, deployment.Name())
 		if err != nil {
 			return deploymentReleases, err