Do not mount unrestricted volumes that overlap BOSH mounts #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous to this commit, there was de-duplication in the volumes mounted, but only if they matched exactly. This commit adds filtering wherein unrestricted volumes will NOT be mounted if they overlap with existing BOSH mounts. BOSH mounts include: * /var/vcap/jobs/<JOB_NAME> * /var/vcap/packages/<JOB_NAME> * /var/vcap/sys/log/<JOB_NAME> among others
rkoster
requested review from
a team,
aramprice and
anshrupani
and removed request for
a team
lnguyen
approved these changes
Jul 3, 2024
aramprice
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous to this commit, there was de-duplication in the volumes mounted, but only if they matched exactly. This commit adds filtering wherein unrestricted volumes will NOT be mounted if they overlap with existing BOSH mounts.
BOSH mounts include: