add ssl termination to log-api #724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[#164176942]
|
✅ Hey MasslessParticle! The commit authors and yourself have already signed the CLA. |
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/164255227 The labels on this github issue will be updated when the story is started. |
|
Hi @MasslessParticle, thanks for the PR! |
|
By default, the routers roll before the log-apis so the log-apis won't advertise/expect the new route until they're ready for it. There shouldn't be downtime. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[#164176942]
Is this a PR to the develop branch of cf-deployment?
Only PR's to develop are accepted.
The RLP Gateway and the Loggregator Trafficcontroller now do ssl termination and register a secure route with the
route_registrarDescribe the change.
This change is made to increase security by making sure all endpoints are secured
Understanding why this change is being made is fantastically helpful. Please do tell...
A security review of loggregator surfaced that the external-facing endpoints from RLP Gateway and Trafficcontroller weren't secured.
Include any links to other PRs, stories, slack discussions, etc... that will help establish context.
Has a cf-deployment including this change passed our cf-acceptance-tests?
How should this change be described in cf-deployment release notes?
Something brief that conveys the change and is written with the Operator audience in mind.
See previous release notes for examples.
Does this PR introduce a breaking change?
This PR will break loggregator until Loggregator Release 105.1 is available and merged into cf-d
Will this change increase the VM footprint of cf-deployment?
Does this PR make a change to an experimental or GA'd feature/component?
What is the level of urgency for publishing this change?
Tag your pair, your PM, and/or team!
It's helpful to tag a few other folks on your team or your team alias in case we need to follow up later.
@jtuchscherer