Remove unnecessary application lookup in buildpack metric generation

cloudfoundry · Jun 18, 2024 · ce93f84 · ce93f84
1 parent 26be714
commit ce93f84
Showing 1 changed file with 6 additions and 9 deletions.
diff --git a/collectors/applications.go b/collectors/applications.go
@@ -259,15 +259,12 @@ func (c ApplicationsCollector) reportApp(application models.Application, objs *m
 	}
 
 	// 3. Use the droplet data for the buildpack metric
-	apps, exists := objs.Apps[application.GUID]
-	if exists {
-		for _, bp := range apps.Lifecycle.Data.Buildpacks {
-			c.applicationBuildpackMetric.WithLabelValues(
-				application.GUID,
-				application.Name,
-				bp,
-			).Set(float64(1))
-		}
+	for _, bp := range application.Lifecycle.Data.Buildpacks {
+		c.applicationBuildpackMetric.WithLabelValues(
+			application.GUID,
+			application.Name,
+			bp,
+		).Set(float64(1))
 	}
 
 	c.applicationInfoMetric.WithLabelValues(