Fix tcp stacking and concurrency handling #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psycofdj
force-pushed
the
fix-tcp-stacking
branch
from
3f58afc
to
d7af15f
Compare
benjaminguttmann-avtq
approved these changes
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where the connections from the exporter to the API are stacking indefinitely until file description exhaustion.
It also fixes #82 where current requests led to exporter stale.
This bug was introduced in v1.0.0 and is cause by an unclosed request body.
This PR also adds the linter golangci-lint, runs it in a workflow and fixes currently detected flaws.
Finally the PR takes the chance to upgrade dependencies.