Print max-in-flight value alongside deployment status [main] #3098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rebasing on main after merge of #3096 |
pivotalgeorge
force-pushed
the
max-in-flight-status-main
branch
from
a4a17a8 to
ffa3f52
Compare
a-b
reviewed
Aug 13, 2024
|
updated with additional commits from #3097 |
Co-authored-by: Greg Weresch <greg.weresch@broadcom.com>
…s table when it is set to non-default value (currently 1) Co-authored-by: Greg Weresch <greg.weresch@broadcom.com>
- these tests depend on a short-lived state Co-authored-by: Greg Weresch <greg.weresch@broadcom.com>
Co-authored-by: João Pereira <joaod@vmware.com>
Co-authored-by: Greg Weresch <greg.weresch@broadcom.com>
pivotalgeorge
force-pushed
the
max-in-flight-status-main
branch
from
86a4e9a to
a2bb971
Compare
nicolasbender
pushed a commit
to sap-contributions/cli
that referenced
this pull request
Nov 5, 2024
…undry#3098) * Deduplicate tests from previous merge Co-authored-by: Greg Weresch <greg.weresch@broadcom.com> * Print max-in-flight value as part of deployment information in process table when it is set to non-default value (currently 1) Co-authored-by: Greg Weresch <greg.weresch@broadcom.com> * Fix flakey tests that look for output from cf app - these tests depend on a short-lived state Co-authored-by: Greg Weresch <greg.weresch@broadcom.com> * Apply suggestions from code review Co-authored-by: João Pereira <joaod@vmware.com> * Refactor app summary displayer tests to use Say instead of MatchRegexp Co-authored-by: Greg Weresch <greg.weresch@broadcom.com> --------- Co-authored-by: Greg Weresch <greg.weresch@broadcom.com> Co-authored-by: João Pereira <joaod@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This prints
max-in-flight: <value>after the deployment status, when there is an Active deployment for an app and when max-in-flight is set to a non-default valueWhy Is This PR Valuable?
It provides the user with information/confirmation that they have set a non-default max-in-flight value
Applicable Issues/PRs
this PR is based on #3096 and is therefore blocked on that PR getting merged into
main+@joaopapereira @weresch