Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the --no-wait flag for cf continue-deployment [v8] #3122

Merged
merged 6 commits into from
Aug 20, 2024

Conversation

chinigo
Copy link
Contributor

@chinigo chinigo commented Aug 19, 2024

Description of the Change

Supports the --no-wait flag for the cf continue-deployment command.

Why Is This PR Valuable?

It brings the continue-deployment command into alignment with other commands that deal with deployments (e.g. cf push, cf restage).

How Urgent Is The Change?

Urgent, as we'd like to include this in our pending release.

Related PRs

@chinigo chinigo marked this pull request as ready for review August 19, 2024 21:58
@chinigo chinigo force-pushed the continue-deployment-with-no-wait-v8 branch from 0696e26 to 7b2b290 Compare August 20, 2024 19:54
@chinigo
Copy link
Contributor Author

chinigo commented Aug 20, 2024

@weresch and @joaopapereira I believe I've now incorporated all of your feedback. Please let me know if I've missed anything! Thanks.

Copy link
Contributor

@weresch weresch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@joaopapereira joaopapereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weresch weresch merged commit 1661f58 into cloudfoundry:v8 Aug 20, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants