Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change how space tip is presented to user - add quotes. Fixes #580 #581

Merged
merged 1 commit into from
Sep 23, 2015
Merged

Conversation

mcowger
Copy link
Contributor

@mcowger mcowger commented Sep 15, 2015

Changes how the space tip is presented, and Fixes issue #580

@cfdreddbot
Copy link

Hey mcowger!

Thanks for submitting this pull request!

All pull request authors must have a Contributor License Agreement (CLA) on-file with us. Please sign the appropriate CLA (individual or corporate).

When sending signed CLA please provide your github username in case of individual CLA or the list of github usernames that can make pull requests on behalf of your organization.

If you are confident that you're covered under a Corporate CLA, please make sure you've publicized your membership in the appropriate Github Org, per these instructions.

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this. You can view the current status of your issue at: https://www.pivotaltracker.com/story/show/103453474.

@camelpunch
Copy link
Contributor

Hey @mcowger! Thanks for the PR. As the bot says, we need to ensure you've signed the CLA before merging even a trivial text change like this. Perhaps you could join a GitHub org that you know has already signed?

@mcowger
Copy link
Contributor Author

mcowger commented Sep 16, 2015

I've sent over the CLA to the CF.org people already - I'm sure they can work it out. I work for EMC, which has already signed, but EMC doesn't let most employees join their GitHub org (life at big companies!), including me :(. I'm a member of the emccode org, but thats separate.

I totally understand the need to wait to merge until we have the stuff signed. I just prefer to get stuff done and send over the PRs while we wait for the business to catch up :).

@camelpunch can you tell me which github orgs from EMC are considered 'approved'? We have multiple.

@camelpunch
Copy link
Contributor

@mcowger these are all of the currently permitted orgs:

  • 18F
  • 84codes
  • ActiveState
  • att-cloudfoundry
  • blueboxgroup
  • altoros
  • anynines
  • appfog
  • cfibmers
  • cfcisco
  • clarkparsia
  • cloudcredo
  • cloudfoundry
  • codethinklabs
  • ECSTeam
  • emcpcf
  • fareoffice
  • Forio
  • fujitsu-cf
  • hpcloud
  • HuaweiTech
  • ibm
  • innovationfactory
  • intalio
  • iron-io
  • libertymutual
  • lds-cf
  • mendix
  • nirds
  • nttlabs
  • nurego
  • OGIS-RI-EOS
  • Orange-OpenSource-Cf
  • piston
  • pivotal
  • pivotal-cf
  • Pivotal-Field-Engineering
  • pivotal-golang
  • rakutentech
  • redislabs
  • sap-cloudfoundry
  • sassoftware
  • searchbox-io
  • sendgrid
  • swisscom
  • symcfmembers
  • Tier3
  • uhurusoftware
  • vchs
  • velankanisys
  • zephirworks
  • ZJU-SEL

@mcowger
Copy link
Contributor Author

mcowger commented Sep 17, 2015

I'm now a member of the emcpcf group which is on the list - should be good from a CLA perspective now.

camelpunch added a commit that referenced this pull request Sep 23, 2015
Change how space tip is presented to user - add quotes.  Fixes #580

[finishes #103453474]
[fixes #103453190]
@camelpunch camelpunch merged commit 01288a8 into cloudfoundry:master Sep 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants