-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v3 should allow to update docker registry credentials #3467
v3 should allow to update docker registry credentials #3467
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you update the docs to show this new support for username and password?
Otherwise seems good. You could consider adding a test at the controller integration level if you wanted to test the flow the whole way through (this test file.) This would allow you to exercise the whole flow with real components, but some might consider it too much for this change. I can probably be convinced either way
Sure, documentation will be updated. Maybe I set it to draft, still working on tests and cases where only password or username is updated :) |
|
8e558d0
to
43dc1a2
Compare
With this PR cloudfoundry/cloud_controller_ng#3467 you do not have to push your app for updating docker credentials, you can also update the latest package and restage your app.
Tested the new PATCH, works with a restage after the PATCH, you can update username and password or just one of them. |
CAPI issue: cloudfoundry#3304 Missing v3 feature parity. PATCH /v3/packages/:guid should allow to update docker registry credentials. This change adds the possibility to update the docker credentials via PATCH /v3/packages/:guid
3485151
to
98ece64
Compare
CAPI issue: #3304 Missing v3 feature parity.
PATCH /v3/packages/:guid should allow to update docker registry credentials.
This change adds the possibility to update the docker credentials via PATCH /v3/packages/:guid. After the PATCH the user has to restage the app in order to compile a new droplet with the new credentials.
Links to any other associated PRs
Docker's registry password #3304
Adapt update docker credentials part docs-dev-guide#494
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
main
branchI have run all the unit tests using
bundle exec rake
I have run CF Acceptance Tests