add 'current_droplet' to app's relationships #3863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmllt
force-pushed
the
add-current-droplet-relationship
branch
from
48c0cf9
to
2d0df2c
Compare
gmllt
changed the title
gmllt
force-pushed
the
add-current-droplet-relationship
branch
2 times, most recently
from
dee18a6
to
a592d39
Compare
gmllt
force-pushed
the
add-current-droplet-relationship
branch
from
a592d39
to
a6196c5
Compare
philippthun
reviewed
Jun 28, 2024
Co-authored-by: Philipp Thun <philipp.thun@sap.com>
…oplet.guid instead
philippthun
approved these changes
Aug 8, 2024
ari-wg-gitbot
added a commit
to cloudfoundry/capi-release
that referenced
this pull request
Aug 8, 2024
Changes in cloud_controller_ng:
- add 'current_droplet' to app's relationships
PR: cloudfoundry/cloud_controller_ng#3863
Author: Gilles Miraillet <gilles.miraillet@orange.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only way to retrieve the current droplet of an application via the API is to go through the
/v3/apps/:app_guid/droplets/currentor/v3/apps/:app_guid/relationships/current_dropletendpoints.In a context where we want to retrieve all the applications (more than 3000 in my case) and their current droplet, it is therefore necessary to make one request per application (more than 3000 requests).
This PR aims to make the current_droplet relationship visible on all endpoints presenting the app object :
/v3/apps/v3/apps/:app_guid/v3/stacks/:stack_id/appsSee issue #3860
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests