Sonar lint fixes

components/credentials/src/main/kotlin/org/cloudfoundry/credhub/requests/CertificateGenerationRequestParameters.kt

@@ -7,7 +7,13 @@ import com.google.common.net.InetAddresses
 import com.google.common.net.InternetDomainName
 import org.apache.commons.lang3.StringUtils.isEmpty
 import org.cloudfoundry.credhub.ErrorMessages
+import org.cloudfoundry.credhub.exceptions.InvalidAlternateNameCertificateException
+import org.cloudfoundry.credhub.exceptions.InvalidDurationCertificateException
+import org.cloudfoundry.credhub.exceptions.InvalidKeyLengthCertificateException
+import org.cloudfoundry.credhub.exceptions.MissingSigningCACertificateException
+import org.cloudfoundry.credhub.exceptions.NoSubjectCertificateException
 import org.cloudfoundry.credhub.exceptions.ParameterizedValidationException
+import org.cloudfoundry.credhub.exceptions.SelfSignedCACertificateException
 import java.util.Arrays
 import java.util.regex.Pattern
 
@@ -83,25 +89,25 @@ class CertificateGenerationRequestParameters {
             isEmpty(commonName) &&
             isEmpty(country)
         ) {
-            throw ParameterizedValidationException(ErrorMessages.MISSING_CERTIFICATE_PARAMETERS)
+            throw NoSubjectCertificateException()
         }
 
         if (isEmpty(caName) && !selfSigned && !isCa) {
-            throw ParameterizedValidationException(ErrorMessages.MISSING_SIGNING_CA)
+            throw MissingSigningCACertificateException()
         }
 
         if (!isEmpty(caName) && selfSigned) {
-            throw ParameterizedValidationException(ErrorMessages.CA_AND_SELF_SIGN)
+            throw SelfSignedCACertificateException()
         }
 
         if (!validKeyLengths.contains(keyLength)) {
-            throw ParameterizedValidationException(ErrorMessages.INVALID_KEY_LENGTH)
+            throw InvalidKeyLengthCertificateException()
         }
 
         if (alternativeNames != null) {
             for (name in alternativeNames!!) {
                 if (!InetAddresses.isInetAddress(name) && !(InternetDomainName.isValid(name) || DNS_WILDCARD_PATTERN.matcher(name).matches())) {
-                    throw ParameterizedValidationException(ErrorMessages.INVALID_ALTERNATE_NAME)
+                    throw InvalidAlternateNameCertificateException()
                 }
             }
         }
@@ -129,7 +135,7 @@ class CertificateGenerationRequestParameters {
         }
 
         if (duration < ONE_DAY || duration > TEN_YEARS) {
-            throw ParameterizedValidationException(ErrorMessages.INVALID_DURATION)
+            throw InvalidDurationCertificateException()
         }
 
         validateParameterLength(commonName, "common name", 64)

components/errors/src/main/kotlin/org/cloudfoundry/credhub/exceptions/InvalidAlternateNameCertificateException.kt

@@ -0,0 +1,8 @@
+package org.cloudfoundry.credhub.exceptions
+
+import org.cloudfoundry.credhub.ErrorMessages
+
+class InvalidAlternateNameCertificateException @JvmOverloads
+    constructor(messageCode: String = ErrorMessages.INVALID_ALTERNATE_NAME, parameters: Array<Any> = arrayOf())
+    : ParameterizedValidationException(messageCode) {
+}

components/errors/src/main/kotlin/org/cloudfoundry/credhub/exceptions/InvalidDurationCertificateException.kt

@@ -0,0 +1,6 @@
+package org.cloudfoundry.credhub.exceptions
+
+import org.cloudfoundry.credhub.ErrorMessages
+
+open class InvalidDurationCertificateException @JvmOverloads constructor(messageCode: String = ErrorMessages.INVALID_DURATION, parameters: Array<Any> = arrayOf())
+        : ParameterizedValidationException(messageCode)

components/errors/src/main/kotlin/org/cloudfoundry/credhub/exceptions/InvalidKeyLengthCertificateException.kt

@@ -0,0 +1,8 @@
+package org.cloudfoundry.credhub.exceptions
+
+import org.cloudfoundry.credhub.ErrorMessages
+
+class InvalidKeyLengthCertificateException @JvmOverloads
+    constructor(messageCode: String = ErrorMessages.INVALID_KEY_LENGTH, parameters: Array<Any> = arrayOf())
+    : ParameterizedValidationException(messageCode) {
+}

components/errors/src/main/kotlin/org/cloudfoundry/credhub/exceptions/MissingSigningCACertificateException.kt

@@ -0,0 +1,8 @@
+package org.cloudfoundry.credhub.exceptions
+
+import org.cloudfoundry.credhub.ErrorMessages
+
+class MissingSigningCACertificateException @JvmOverloads
+    constructor(messageCode: String = ErrorMessages.MISSING_SIGNING_CA, parameters: Array<Any> = arrayOf())
+    : ParameterizedValidationException(messageCode) {
+}

components/errors/src/main/kotlin/org/cloudfoundry/credhub/exceptions/NoSubjectCertificateException.kt

@@ -0,0 +1,8 @@
+package org.cloudfoundry.credhub.exceptions
+
+import org.cloudfoundry.credhub.ErrorMessages
+
+class NoSubjectCertificateException @JvmOverloads
+    constructor(messageCode: String = ErrorMessages.MISSING_CERTIFICATE_PARAMETERS, parameters: Array<Any> = arrayOf())
+    : ParameterizedValidationException(messageCode) {
+}

components/errors/src/main/kotlin/org/cloudfoundry/credhub/exceptions/ParameterizedValidationException.kt

@@ -4,7 +4,7 @@ import com.google.common.collect.Lists
 import java.util.stream.Collectors
 import javax.validation.ValidationException
 
-class ParameterizedValidationException @JvmOverloads constructor(messageCode: String, parameters: Array<Any> = arrayOf()) : ValidationException(messageCode) {
+open class ParameterizedValidationException @JvmOverloads constructor(messageCode: String, parameters: Array<Any> = arrayOf()) : ValidationException(messageCode) {
 
     private val parameters: List<Any>
 

components/errors/src/main/kotlin/org/cloudfoundry/credhub/exceptions/SelfSignedCACertificateException.kt

@@ -0,0 +1,8 @@
+package org.cloudfoundry.credhub.exceptions
+
+import org.cloudfoundry.credhub.ErrorMessages
+
+class SelfSignedCACertificateException @JvmOverloads
+    constructor(messageCode: String = ErrorMessages.CA_AND_SELF_SIGN, parameters: Array<Any> = arrayOf())
+    : ParameterizedValidationException(messageCode) {
+}