Update README.md - Remove Vagrant and Virtual Box #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove Vagrant and Virtual Box from the recommended tools as all work is in Docker now.
| @@ -76,8 +76,6 @@ In order to contribute to the project you may want some of the following install | |||
| - [Go](https://golang.org/doc/install#install) - The Go programming | |||
| language | |||
| - [Fly CLI](https://github.com/concourse/fly) - Concourse CLI | |||
| - [Virtualbox](https://www.virtualbox.org/) - Virtualization box | |||
| - [Vagrant](https://www.vagrantup.com/) - Portable dev environment | |||
There was a problem hiding this comment.
The only reason one would need these things is to deploy concourse locally. I think the link in readme for deploying concourse is also incorrect. I think I am in favor or either removing both references and rely on folks having concourse deployed outside of this repo or leave VirtualBox and Vagrant and fix the link to point to valid guide.
There was a problem hiding this comment.
Fair points. I'll work on trying to get the documentation updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove Vagrant and Virtual Box from the recommended tools as all work is in Docker now.