Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs #358

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Update docs #358

wants to merge 3 commits into from

Conversation

bgandon
Copy link

@bgandon bgandon commented Jul 6, 2024

Hi there,
After reading the docs related to ContainerD support in Garden, I'm suggesting here in this PR some fixes and minor additions.
Individual commits are specifically crafted to decompose the various edits and their intents.
Thanks for the great work you guys are doing! 👏
Best,
Benjamin

@bgandon bgandon requested a review from a team as a code owner July 6, 2024 10:35
@bgandon
Copy link
Author

bgandon commented Jul 11, 2024

Ping for review, this is only a documentation change 🙂

Copy link
Contributor

@winkingturtle-vmw winkingturtle-vmw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bgandon Thank you for these doc updates. Sorry it's taken so long to review them. I think they all look good. If you can please address the comments I left, we can start the merge process

have a look at the [runc mode ops guide](opsguide-runc.md#processes) for more details.
The containerd mode is limited to container operations. There has been an
experimental option for handling processes operations by ContainerD instead of
RunC since v1.15.0 (as of 2028-06-18), but it has been deprecated in v1.53.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the date is 2024-06-18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants