Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhacements to support external networkers #48

Conversation

jaydunk
Copy link

@jaydunk jaydunk commented Aug 16, 2016

  • Network sets ExternalIP property and configures DNS resolv conf
  • NetIn allocates ports from port pool and persists them to the container's MappedPorts
  • NetOut persists rules to a well-named container property, so that external components may discover the full set of rules

Story #127325611

cc @rosenhouse

- Network() sets ExternalIP and configures DNS resolv conf
- NetIn allocates ports from port pool and persists them to the container's
  MappedPorts
- NetOut persists rules to a well-named container property, so that external
  components may discover the full set of rules

[#127325611]

Signed-off-by: Gabe Rosenhouse <grosenhouse@pivotal.io>
@cfdreddbot
Copy link

Hey jaydunk!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@garden-gnome
Copy link

Hi there!

We use Pivotal Tracker to provide visibility into what our team is working on. A story for this issue has been automatically created.

The current status is as follows:

  • #128464261 Enhacements to support external networkers

This comment, as well as the labels on the issue, will be automatically updated as the status in Tracker changes.

@teddyking
Copy link
Contributor

Just a random question, is there some reason we don't log the stdin here: https://github.com/cf-container-networking/guardian/blob/71447d9008d1c687981d0769f9ac2b302b05cec2/netplugin/external_networker.go#L220 ?

Everything else seems good to us.

@rosenhouse
Copy link
Contributor

No particular reason. Feel free to add when you do the merge.

Also, feel free to squash that ugly history :-)

On Tuesday, September 6, 2016, Ed King notifications@github.com wrote:

Just a random question, is there some reason we don't log the stdin here:
https://github.com/cf-container-networking/guardian/blob/
71447d9/netplugin/external_
networker.go#L220 ?

Everything else seems good to us.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#48 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AD7_CavTHjaD2RbMxkrK1zBy5LlmRgLIks5qnWtRgaJpZM4Jl8Wb
.

@teddyking teddyking merged commit 71447d9 into cloudfoundry:master Sep 6, 2016
@teddyking
Copy link
Contributor

All merged, thanks for the PR c2c!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants