-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhacements to support external networkers #48
Enhacements to support external networkers #48
Conversation
- Network() sets ExternalIP and configures DNS resolv conf - NetIn allocates ports from port pool and persists them to the container's MappedPorts - NetOut persists rules to a well-named container property, so that external components may discover the full set of rules [#127325611] Signed-off-by: Gabe Rosenhouse <grosenhouse@pivotal.io>
Hey jaydunk! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
Hi there! We use Pivotal Tracker to provide visibility into what our team is working on. A story for this issue has been automatically created. The current status is as follows:
This comment, as well as the labels on the issue, will be automatically updated as the status in Tracker changes. |
Signed-off-by: Mark St.Godard <markstgodard@gmail.com>
[#128812269] Signed-off-by: David Bellotti <dbellotti@pivotal.io>
[#128812265]
Just a random question, is there some reason we don't log the stdin here: https://github.com/cf-container-networking/guardian/blob/71447d9008d1c687981d0769f9ac2b302b05cec2/netplugin/external_networker.go#L220 ? Everything else seems good to us. |
No particular reason. Feel free to add when you do the merge. Also, feel free to squash that ugly history :-) On Tuesday, September 6, 2016, Ed King notifications@github.com wrote:
|
All merged, thanks for the PR c2c! |
Network
sets ExternalIP property and configures DNS resolv confNetIn
allocates ports from port pool and persists them to the container's MappedPortsNetOut
persists rules to a well-named container property, so that external components may discover the full set of rulesStory #127325611
cc @rosenhouse