-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Download sealights agent from 'customAgentUrl' #1050
base: main
Are you sure you want to change the base?
Download sealights agent from 'customAgentUrl' #1050
Conversation
Added support for the new parameter both from app configuration and sealights user-provided service Searching for jar which name starts with 'sl-test-listener' in zip downloaded from customAgentUrl Overwrite sl.enableUpgrade to false when agent is downloaded from customAgentUrl 'enable_upgrade' parameter name fix in config yml file ('auto_upgrade' was not used in sealights framework) Modified adding system property sl.tag to contain buildpack version
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
REviewed and tested internally
@pivotal-david-osullivan can I ask you for review and merging this PR? |
Hello Java Buildpack Team. We would like to merge this PR to Sealights' buildpack. Could you please give me a suggestion what I should do to get review/approval and merging for this PR? |
Hello! In the case of sealights agent, if you look at the default configuration, you'll guess that the dependency is fetched from the latest in https://agents.sealights.co/pcf/index.yml So if you rebuilt the
to
and then published at https://my-own-bucket.com/index.yml a file with your own packaging of sealights, you'd be done. Please let me know why you decided to divert from this way of providing different dependencies. |
Hi @anthonydahanne |
Anthony is correct, you must host the
|
Download sealights agent from 'customAgentUrl'
Some our customers want to have possibility to download specific Sealights agent from their internal URL instead of public Sealights servers. We want to provide them the easy way to configure it by adding a new parameter 'customAgentUrl'.
Sealights buildpacks should support the same parameter for the same template across all technologies that is why we add 'customAgentUrl' instead of 'custom_agent_url'.
This PR contains also: