Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension point for supplying an external Tomcat configuration #274

Closed
wants to merge 1 commit into from
Closed

Extension point for supplying an external Tomcat configuration #274

wants to merge 1 commit into from

Conversation

violetagg
Copy link
Contributor

Hi,

I would like to propose an extension point for supplying a Tomcat configuration without forking the buildpack.

The new component is disabled by default and can be enabled in case an external Tomcat configuration will be used.

The mechanism for overlaying the configuration will not be changed.

  1. Default Tomcat configuration
  2. Tomcat configuration provided by the buildpack
  3. External Tomcat configuration if it is enabled.

The external Tomcat configuration must be supplied in TAR format and must follow the Tomcat archive structure.

The external Tomcat configuration will not be modified so the supplier should guarantee that the symlinks are allowed.

I would be glad to hear your opinion.

Thanks,
Violeta

@cfdreddbot
Copy link

Hey violetagg!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you've already signed the CLA.

@testobsessed
Copy link

 Code Climate has analyzed this pull request.

@cgfrost
Copy link
Contributor

cgfrost commented Feb 22, 2016

I'm happy with the code changes.

@nebhale
Copy link
Member

nebhale commented Feb 25, 2016

Resolved with b2bdeb8

@nebhale nebhale closed this Feb 25, 2016
@violetagg
Copy link
Contributor Author

Thanks a lot
Violeta

@violetagg violetagg deleted the tomcat_external_configuration branch February 26, 2016 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants