Skip to content

Commit

Permalink
Fix line number reporting on an e2e test failure
Browse files Browse the repository at this point in the history
Our fail handler wrapper was not skipping enough stack frames

Co-authored-by: Kieron Browne <kbrowne@vmware.com>
  • Loading branch information
2 people authored and georgethebeatle committed Jul 20, 2023
1 parent 6ca7166 commit 32dcdc9
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions tests/e2e/helpers/fail_handler.go
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,9 @@ func E2EFailHandler(correlationId func() string) func(string, ...int) {
fmt.Fprintf(ginkgo.GinkgoWriter, "Fail Handler: failure correlation ID: %q\n", correlationId())

if len(callerSkip) > 0 {
callerSkip[0] = callerSkip[0] + 1
callerSkip[0] = callerSkip[0] + 2
} else {
callerSkip = []int{1}
callerSkip = []int{2}
}

defer func() {
Expand Down

0 comments on commit 32dcdc9

Please sign in to comment.