Remove the api.builderName helm param

 - The api.builderName helm param is redundant
 - There is already a global.reconcilers.build param that is being used
   instead

[#2650]

README.helm.md

@@ -20,7 +20,7 @@ Here are all the values that can be set for the chart:
   - `logLevel` (_String_): Sets level of logging for api and controllers components. Can be 'info' or 'debug'.
   - `reconcilers`:
     - `app` (_String_): ID of the workload runner to set on all `AppWorkload` objects. Defaults to `statefulset-runner`.
-    - `build` (_String_): ID of the image builder to set on all `BuildWorkload` objects. Has to match `api.builderName`. Defaults to `kpack-image-builder`.
+    - `build` (_String_): ID of the image builder to set on all `BuildWorkload` objects. Defaults to `kpack-image-builder`.
   - `rootNamespace` (_String_): Root of the Cloud Foundry namespace hierarchy.
 - `adminUserName` (_String_): Name of the admin user that will be bound to the Cloud Foundry Admin role.
 - `api`:
@@ -36,7 +36,6 @@ Here are all the values that can be set for the chart:
   - `authProxy`: Needed if using a cluster authentication proxy, e.g. [Pinniped](https://pinniped.dev/).
     - `caCert` (_String_): Proxy's PEM-encoded CA certificate (*not* as Base64).
     - `host` (_String_): Must be a host string, a host:port pair, or a URL to the base of the apiserver.
-  - `builderName` (_String_): ID of the builder used to build apps. Defaults to `kpack-image-builder`.
   - `expose` (_Boolean_): Expose the API component via Contour. Set to false if you want to expose the API using other means.
   - `image` (_String_): Reference to the API container image.
   - `include` (_Boolean_): Deploy the API component.

helm/korifi/values.schema.json

@@ -54,7 +54,7 @@
           "type": "object",
           "properties": {
             "build": {
-              "description": "ID of the image builder to set on all `BuildWorkload` objects. Has to match `api.builderName`. Defaults to `kpack-image-builder`.",
+              "description": "ID of the image builder to set on all `BuildWorkload` objects. Defaults to `kpack-image-builder`.",
               "type": "string"
             },
             "app": {
@@ -201,10 +201,6 @@
           },
           "required": ["type", "stack", "stagingRequirements"]
         },
-        "builderName": {
-          "description": "ID of the builder used to build apps. Defaults to `kpack-image-builder`.",
-          "type": "string"
-        },
         "userCertificateExpirationWarningDuration": {
           "description": "Issue a warning if the user certificate provided for login has a long expiry. See [`time.ParseDuration`](https://pkg.go.dev/time#ParseDuration) for details on the format.",
           "type": "string"
@@ -230,7 +226,6 @@
         "apiServer",
         "image",
         "lifecycle",
-        "builderName",
         "userCertificateExpirationWarningDuration"
       ],
       "type": "object"

helm/korifi/values.yaml

@@ -49,7 +49,6 @@ api:
       diskMB: 0
       buildCacheMB: 2048
 
-  builderName: kpack-image-builder
   userCertificateExpirationWarningDuration: 168h
 
   authProxy: