Rename experimental services flag

The flag is already called experimentalManagedServicesEnabled in the configmap and in the code, so let's be consistent Enabled sounds more appropriate than include, since it is a crosscutting feature and not a component the you can include/exclude
cloudfoundry · Oct 18, 2024 · eb21836 · eb21836
1 parent 82c2d66
commit eb21836
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 7 deletions.
diff --git a/helm/korifi/api/configmap.yaml b/helm/korifi/api/configmap.yaml
@@ -53,7 +53,7 @@ data:
     {{- if .Values.eksContainerRegistryRoleARN }}
     containerRegistryType: "ECR"
     {{- end }}
-    experimentalManagedServicesEnabled: {{ .Values.experimental.managedServices.include }}
+    experimentalManagedServicesEnabled: {{ .Values.experimental.managedServices.enabled }}
   role_mappings_config.yaml: |
     roleMappings:
       admin:

diff --git a/helm/korifi/controllers/configmap.yaml b/helm/korifi/controllers/configmap.yaml
@@ -57,6 +57,6 @@ data:
     networking:
       gatewayNamespace: {{ .Release.Namespace }}-gateway
       gatewayName: korifi
-    experimentalManagedServicesEnabled: {{ .Values.experimental.managedServices.include }}
+    experimentalManagedServicesEnabled: {{ .Values.experimental.managedServices.enabled }}
     trustInsecureServiceBrokers: {{ .Values.experimental.managedServices.trustInsecureBrokers }}
 
diff --git a/helm/korifi/values.yaml b/helm/korifi/values.yaml
@@ -10,8 +10,6 @@ eksContainerRegistryRoleARN: ""
 containerRegistryCACertSecret:
 systemImagePullSecrets: []
 
-experimentalManagedServicesEnabled: false
-
 reconcilers:
   build: kpack-image-builder
   run: statefulset-runner
@@ -145,5 +143,5 @@ networking:
 
 experimental:
   managedServices:
-    include: false
+    enabled: false
     trustInsecureBrokers: false
diff --git a/scripts/deploy-on-kind.sh b/scripts/deploy-on-kind.sh
@@ -205,7 +205,7 @@ function deploy_korifi() {
       --set=networking.gatewayClass="contour" \
       --set=networking.gatewayPorts.http="32080" \
       --set=networking.gatewayPorts.https="32443" \
-      --set=experimental.managedServices.include="true" \
+      --set=experimental.managedServices.enabled="true" \
       --set=experimental.managedServices.trustInsecureBrokers="true" \
       --wait
   }

diff --git a/scripts/installer/install-korifi-kind.yaml b/scripts/installer/install-korifi-kind.yaml
@@ -113,7 +113,7 @@ spec:
             --set=networking.gatewayClass="contour" \
             --set=networking.gatewayPorts.http="32080" \
             --set=networking.gatewayPorts.https="32443" \
-            --set=experimental.managedServices.include="true" \
+            --set=experimental.managedServices.enabled="true" \
             --set=experimental.managedServices.trustInsecureBrokers="true" \
             --wait