Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a Korifi API user I want to be able to create apps with docker lifecycle so that I am enabled to run workloads backed up by docker images #2790

Closed
danail-branekov opened this issue Aug 17, 2023 · 0 comments
Labels
docker Pull requests that update Docker code
Milestone

Comments

@danail-branekov
Copy link
Member

danail-branekov commented Aug 17, 2023

GIVEN Korifi is deployed on a k8s cluster

WHEN I create an app with docker lifecycle:

curl "https://api.example.org/v3/apps" \
  -X POST \
  -H "Authorization: bearer [token]" \
  -H "Content-type: application/json" \
  -d '{
    "name": "my_app",
    "relationships": {
      "space": {
        "data": {
          "guid": "2f35885d-0c9d-4423-83ad-fd05066f8576"
        }
      }
    },
    "lifecycle": {
      "type": "docker",
      "data": {}
    }
  }'

THEN I see that the request above succeeds and a response similar to

HTTP/1.1 201 Created
Content-Type: application/json

{
  "guid": "1cb006ee-fb05-47e1-b541-c34179ddc446",
  "name": "my_app",
  "state": "STOPPED",
  "created_at": "2016-03-17T21:41:30Z",
  "updated_at": "2016-06-08T16:41:26Z",
  "lifecycle": {
    "type": "docker",
    "data": {}
  }
}
@danail-branekov danail-branekov added the docker Pull requests that update Docker code label Aug 17, 2023
danail-branekov added a commit that referenced this issue Aug 22, 2023
* Allow `docker` lifecycle type in the `Lifecycle` object
* Omit empty `LifecycleData` attributes in the app response
* LifecycleData is required to be an empty object if the lifecycle type
  is `docker`

Issue: #2790

Co-authored-by: Georgi Sabev <georgethebeatle@gmail.com>
danail-branekov pushed a commit that referenced this issue Aug 22, 2023
* Allow `docker` lifecycle type in the `Lifecycle` object
* Omit empty `LifecycleData` attributes in the app/droplet response
* LifecycleData is required to be an empty object if the lifecycle type
  is `docker`

Issue: #2790

Co-authored-by: Georgi Sabev <georgethebeatle@gmail.com>
danail-branekov pushed a commit that referenced this issue Aug 22, 2023
* Allow `docker` lifecycle type in the `Lifecycle` object
* Omit empty `LifecycleData` attributes in the app/droplet response
* LifecycleData is required to be an empty object if the lifecycle type
  is `docker`

Issue: #2790

Co-authored-by: Georgi Sabev <georgethebeatle@gmail.com>
georgethebeatle added a commit that referenced this issue Aug 23, 2023
* Allow `docker` lifecycle type in the `Lifecycle` object
* Omit empty `LifecycleData` attributes in the app/droplet response
* LifecycleData is required to be an empty object if the lifecycle type
  is `docker`

Issue: #2790

Co-authored-by: Georgi Sabev <georgethebeatle@gmail.com>
@georgethebeatle georgethebeatle modified the milestones: v0.10, v0.9 Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docker Pull requests that update Docker code
Projects
Archived in project
Development

No branches or pull requests

2 participants