Implement DELETE /v3/roles/guid #2117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fix listing functionality to read the role guid that gets returned to the user from the CFRole metadata, as the CFRole name contains the sha256 sum of the role name and the user name, so that optimistic locking will prevent us from creating duplicate entries Co-authored-by: Danail Branekov <danailster@gmail.com> Co-authored-by: Georgi Sabev <georgethebeatle@gmail.com>
danail-branekov
force-pushed
the
issues/1239-delete-roles
branch
from
a51232a
to
e7bb0a4
Compare
danail-branekov
approved these changes
Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a related GitHub Issue?
#1239
What is this change about?
Implement DELETE /v3/role/{guid}
Also fix listing functionality to read the role guid that gets returned
to the user from the CFRole metadata, as the CFRole name contains the
sha256 sum of the role name and the user name, so that optimistic
locking will prevent us from creating duplicate entries
Does this PR introduce a breaking change?
No
Acceptance Steps
See story
Tag your pair, your PM, and/or team
@eirini
Things to remember