Set VCAP_APPLICATION env var in apps #2187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This creates a new secret for VCAP_APPLICATION env var in the CFApp reconciler. Its contents are returned when getting the app env endpoint. Issue: #2140 Co-authored-by: Georgi Sabev <georgethebeatle@gmail.com>
This introduces an e2e helper to curl pushed apps (curlApp), and vendirs dora from cf-acceptances-tests into a zip so we can have an app that can report its own env. Issue: #2140 Co-authored-by: Kieron Browne <kbrowne@vmware.com>
Co-authored-by: Georgi Sabev <georgethebeatle@gmail.com>
We can use a parameterised resourceList struct instead Co-authored-by: Kieron Browne <kbrowne@vmware.com>
Co-authored-by: Georgi Sabev <georgethebeatle@gmail.com>
Wait until the controller cache has picked up changes just made when setting up the tests Co-authored-by: Kieron Browne <kbrowne@vmware.com>
Apps now expect to be in spaces, so it is not sufficient to just create a k8s namespace and put a CFApp in it - we now create a cf org in the before suite, and create cf spaces in the tests. Co-authored-by: Georgi Sabev <georgethebeatle@gmail.com>
Co-authored-by: Kieron Browne <kbrowne@vmware.com>
kieron-dev
force-pushed
the
issues/2140-vcap-application-envvar
branch
from
e5e4826
to
93aa43f
Compare
georgethebeatle
approved these changes
Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a related GitHub Issue?
#2140
What is this change about?
We now create VCAP_APPLICATION secret (similar to the existing VCAP_SERVICES) secret in the CFApp reconciler. This is set in the runworkload and taskworkloads so that apps and tasks have the env var set.
This triggered a set of changes:
Does this PR introduce a breaking change?
No
Acceptance Steps
Push an app:
Tag your pair, your PM, and/or team
@georgethebeatle