Container images are deleted alongside packages #2257
Conversation
kieron-dev
force-pushed
the
issues/2228-delete-package-images
branch
2 times, most recently
from
c55a962
to
5dfc8d2
Compare
|
Converting to draft as we seem to have dangling tags |
| imageDeleter.DeleteReturns(errors.New("oops")) | ||
| }) | ||
|
|
||
| It("ignores the errors and finishes finalization", func() { |
There was a problem hiding this comment.
Cool I think this is good. I was worried about an external resource outage blocking finalization. Any ideas around how to make this scenario easier for operators to detect though? It reminds me of the "orphaned blob" problem that CF for VMs found itself dealing with.
|
When we tried to do this back in the day on CF for K8s we found a lot of variance between registries around how they handled image deletion. I'm having trouble remembering the specifics, but I'm thinking some had non-standard delete endpoints (probably DockerHub?) while others supported the ability to delete by digest and others did not. Anyways, I'm wondering if y'all ran into similar issues here? |
kieron-dev
force-pushed
the
issues/2228-delete-package-images
branch
2 times, most recently
from
8118ee8
to
0f320a6
Compare
Issue: #2228 Co-authored-by: Giuseppe Capizzi <gcapizzi@vmware.com>
kieron-dev
force-pushed
the
issues/2228-delete-package-images
branch
from
0f320a6
to
f559b52
Compare
Is there a related GitHub Issue?
#2228
What is this change about?
Does this PR introduce a breaking change?
No
Acceptance Steps
Push an app.
See its package image exists in a registry
Delete the app.
See the image disappear
Tag your pair, your PM, and/or team
@gcapizzi