Actually wait for the CFOrg to be deleted in job endpoint #2702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, the job endpoint would say that an org was deleted as soon as the CFOrg finalizer removed their role binding from the Org namespace. We now fetch the CFOrg directly to determine if it's done deleting. If it isn't deleting, then we will use GetOrg to determine if the user has access to the org [#2605]
davewalter
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a related GitHub Issue?
[#2605]
What is this change about?
Before this change, the job endpoint would say that an org was deleted as soon as the CFOrg finalizer removed their role binding from the Org namespace. We now fetch the CFOrg directly to determine if it's done deleting. If it isn't deleting, then we will use GetOrg to determine if the user has access to the org
Does this PR introduce a breaking change?
NoAcceptance Steps
Follow AC for the issueTag your pair, your PM, and/or team
@davewalter @gcapizzi @georgethebeatle