Refactor smoke tests #2721
Merged
Refactor smoke tests #2721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcapizzi
force-pushed
the
wip-refactor-smoke-tests
branch
from
067a2e5
to
0e02ca9
Compare
Co-authored-by: Georgi Sabev <georgethebeatle@gmail.com>
georgethebeatle
force-pushed
the
wip-refactor-smoke-tests
branch
2 times, most recently
from
e05f68a
to
5d8e8ea
Compare
Also improve the structure of the smoke test Co-authored-by: Georgi Sabev <georgethebeatle@gmail.com>
georgethebeatle
force-pushed
the
wip-refactor-smoke-tests
branch
2 times, most recently
from
9bf6491
to
dbf11e6
Compare
Co-authored-by: Georgi Sabev <georgethebeatle@gmail.com>
georgethebeatle
force-pushed
the
wip-refactor-smoke-tests
branch
from
dbf11e6
to
dca0124
Compare
gcapizzi
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a related GitHub Issue?
No
What is this change about?
Refactor smoke tests
Also pointing all e2e-style tests to the same apps. This way we avoid
having similar assets for every tests suite
Does this PR introduce a breaking change?
No
Acceptance Steps
Green tests
Tag your pair, your PM, and/or team
@gcapizzi