Generate users on the fly in tests #2765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgethebeatle
previously approved these changes
Aug 10, 2023
georgethebeatle
force-pushed
the
issues/2519-simplify-e2e-suite
branch
from
87bed69
to
e50f592
Compare
georgethebeatle
previously approved these changes
Aug 11, 2023
danail-branekov
force-pushed
the
issues/2519-simplify-e2e-suite
branch
from
e50f592
to
ee51fdd
Compare
georgethebeatle
previously approved these changes
Aug 11, 2023
georgethebeatle
force-pushed
the
issues/2519-simplify-e2e-suite
branch
from
ee51fdd
to
6bd6015
Compare
georgethebeatle
previously approved these changes
Aug 11, 2023
georgethebeatle
force-pushed
the
issues/2519-simplify-e2e-suite
branch
4 times, most recently
from
f78ea0d
to
b0ed3ac
Compare
georgethebeatle
previously approved these changes
Aug 14, 2023
instead of relying them being created in advance User management is backed up by creating service accounts on the fly, and use their tokens to create CF API rest clients. For tests that verify certificate authentication we generate certificates on the fly as well. However, on EKS signing certificates with `client auth` usage is not supported, therefore we skip those tests. As a matter of fact, those tests have already been skipped on EKS by simply not injecting the certificate related environment variables. All of the above will simplify CI setup significantly. Co-authored-by: Danail Branekov <danailster@gmail.com> Co-authored-by: Georgi Sabev <georgethebeatle@gmail.com>
georgethebeatle
force-pushed
the
issues/2519-simplify-e2e-suite
branch
from
b0ed3ac
to
d9855a9
Compare
danail-branekov
changed the title
georgethebeatle
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a related GitHub Issue?
#2519
What is this change about?
Generate user accounts on the fly in tests
instead of relying them being created in advance
User management is backed up by creating service accounts on the fly,
and use their tokens to create CF API rest clients.
For tests that verify certificate authentication we generate
certificates on the fly as well. However, on EKS signing certificates
with
client authusage is not supported, therefore we skip thosetests. As a matter of fact, those tests have already been skipped on
EKS by simply not injecting the certificate related environment
variables.
All of the above will simplify CI setup significantly.
Does this PR introduce a breaking change?
No
Acceptance Steps
E2E tests passing
Tag your pair, your PM, and/or team
@georgethebeatle