Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when applying manifests referencing unexisting services #2805

Merged
merged 2 commits into from
Aug 18, 2023

Conversation

danail-branekov
Copy link
Member

Is there a related GitHub Issue?

#2322

What is this change about?

App manifest application with service bindings fails if service instance is not found

Does this PR introduce a breaking change?

No

Acceptance Steps

N/A

Tag your pair, your PM, and/or team

@georgethebeatle

Co-authored-by: Danail Branekov <danailster@gmail.com>
@georgethebeatle georgethebeatle enabled auto-merge (rebase) August 18, 2023 10:18
@georgethebeatle georgethebeatle linked an issue Aug 18, 2023 that may be closed by this pull request
@georgethebeatle georgethebeatle merged commit 23f012c into main Aug 18, 2023
7 checks passed
@georgethebeatle georgethebeatle deleted the issues/2322-error-missing-services-in-manifest branch August 18, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Korifi API users can push manifests with services
2 participants