Setup logger in context in the patching reconciler #2830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danail-branekov
requested review from
georgethebeatle and
davewalter
and removed request for
georgethebeatle
Thus reconcilers that use the patching reconciler (i.e. all Korifi reconcilers) can take a logger from the context (`logr.FromContextOrDiscard`) that has been set up with object namespace, name and an unique logID
danail-branekov
force-pushed
the
setup-logger-in-patching-reconciler
branch
from
a7068e6
to
d73b46a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a related GitHub Issue?
No
What is this change about?
Setup a logger in the patching reconciler and inject it into the context that is passed to concrete object reconcilers. This way object reconcilers can just use that logger and not bother setting it up themselves.
This PR is a response to @davewalter's comment. Dave, could you please review this one?
Does this PR introduce a breaking change?
No
Acceptance Steps
Controllers logs appear
Tag your pair, your PM, and/or team
@davewalter